Allow testing feature branches, and allow manual trigger via GH UI - #1355
Allow testing feature branches, and allow manual trigger via GH UI#1355hugovk wants to merge 1 commit into
Conversation
|
What about just adding workflow_dispatch (which allows checking locally), but not removing the branch filter? Any in-repo job (like all Dependabot runs!) now will run 120+ jobs instead of the normal 60+. |
That's also friction:
Or some
Personally, I don't think that's much of a problem for max two Dependabot PRs per month, plus the occasional security PR. I doubt anyone will even notice it, and it's not much extra CI time. If it's a blocker, we can add a guard to prevent in-repo, non- if: github.event_name != 'push' || github.event.repository.fork || github.ref_name == 'main' |
2 participants
I prefer to make sure my code passes on CI, before opening a PR and pinging all maintainers.
Right now, this CI only runs on pushes to
main. This means I can only work on one PR at a time, and if I forget I have a PR open frommain, I can accidentally close it by resetting to upstream: #1263 (comment)Yes, but I recommend creating PRs from your own fork and not from upstream:
It's not common. Of the last 300 PRs to this repo, only 16 were in-repo:
And the CI is fast, it doesn't use up too much time.
Plus, they're technically not really double-runs, a
pushand apull_requesttest different things. Apushis just what's on the branch. Apull_requestsimulates a merge againstmain, and tests that. Occasionally you get different results, and this can be useful info!Indeed, but that's also adding extra friction to contribution.